Skip to content

Seeing a FutureWarning for .is_datetime64tz_dtype from figure_resampler_interface #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darynwhite opened this issue Oct 24, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@darynwhite
Copy link

elif pd.core.dtypes.common.is_datetime64tz_dtype(hf_trace_data[k]):

The line above is referenced when I generate a plot a resampler figure in a iPython Notebook, here is the error output:

lib/python3.11/site-packages/plotly_resampler/figure_resampler/figure_resampler_interface.py:327:
FutureWarning:

is_datetime64tz_dtype is deprecated and will be removed in a future version. Check `isinstance(dtype, pd.DatetimeTZDtype)` instead.

I'm running the latest release, 0.9.1

@jonasvdd
Copy link
Member

Hi @darynwhite,

Thanks for reporting this issue, it can easily be fixed.
I will look into it today!

I expect to create a new release somewhere later this week.

p.s.: This release will include some new features, such as a rangeslider 🔥 (see 📷 ⬇️ )

Peek 2023-10-25 01-51

@jonasvdd jonasvdd self-assigned this Oct 24, 2023
@jonasvdd jonasvdd added the bug Something isn't working label Oct 24, 2023
jonasvdd added a commit that referenced this issue Oct 25, 2023
jonasvdd added a commit that referenced this issue Oct 25, 2023
* fix for #263

* 🙈
@jonasvdd
Copy link
Member

PR is merged! :)

@darynwhite
Copy link
Author

Is there going to be a release including this fix (and the other updates) or will I need to build this locally to test?

Thanks!

@jonasvdd
Copy link
Member

If all goes well, we will create a new release candidate tomorrow! :)

@jonasvdd
Copy link
Member

There is one more test that is failing, as I am now on holidy I will look into this somewhere later this week! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants