Skip to content

no support for dict representation of plotly traces #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvdd opened this issue Jun 7, 2022 · 1 comment
Closed

no support for dict representation of plotly traces #69

jvdd opened this issue Jun 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jvdd
Copy link
Member

jvdd commented Jun 7, 2022

The following code works in plotly, but does not work when wrapping the constructor with FigureResampler.

trace = {
    "type": "scatter",
        #  "x": [1, 2, 3],
    "y": np.arange(5_000),
    "name": "some_trace",  # is not even required
}
fig = go.Figure()  # wrapping this will fail
fig.add_trace(trace)

We can support dict representation on 2 places;

  1. in the constructor of AbstractFigureAggregator (-> not really sure if we want to do this)
  2. in the add_trace method -> our type hinting indicates that we support dict input, but this is clearly not the case
@jvdd jvdd added the bug Something isn't working label Jun 7, 2022
@jvdd jvdd mentioned this issue Jun 9, 2022
11 tasks
@jonasvdd
Copy link
Member

jonasvdd commented Jun 17, 2022

should be fixed with #70, and will be released with plotly-resampler 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants