-
-
Notifications
You must be signed in to change notification settings - Fork 73
✨ register plotly-resampler #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 98.47% 98.11% -0.36%
==========================================
Files 9 10 +1
Lines 589 743 +154
==========================================
+ Hits 580 729 +149
- Misses 9 14 +5
Continue to review full report at Codecov.
|
What also seems a cool feature is having the option to set For example, when you work in vscode notebooks, it is rather convenient to always work with a figurewidget! |
fyi: I would opt to not override the default Calling |
if figure is None: | ||
figure = go.Figure() | ||
if not is_figure(figure): # TODO: does this make sense? | ||
figure = go.Figure(figure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs some profiling before we decide whether this will be done.
I think you should first check whether the object is a FigureAggregator instance, otherwise it will most likely loose the current _hf_data
properties
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has the following contributions;
plotly-resampler
register_plotly_express
(e.g., environment, port)add_traces
FigureResampler
andFigureWidgetResampler
composable see 🗳️ Compose figs #72Other minor changes
utils.py
+ add tests