Skip to content

🐛 update layout axes range bug #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2022
Merged

🐛 update layout axes range bug #126

merged 8 commits into from
Oct 22, 2022

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Oct 20, 2022

Fixes #119

This PR does the following;

  • set default value for xaxis and yaxis autorange to None
  • trigger downsampling in FigureResampler.show_dash when an xaxis has its own range in the layout
  • add tests
  • update poetry CI-CD

TODO: properly look at reset axes and/or autoscale behavior - this does not reset axes as we would expect (bc original range not in front-end..?)

(P.S. once merged into main we should update PR #115 with the latest main)

@jvdd jvdd mentioned this pull request Oct 20, 2022
5 tasks
@jvdd jvdd requested a review from jonasvdd October 20, 2022 14:22
@jvdd jvdd changed the title 🐛 fix update layout axes range bug 🐛 update layout axes range bug Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #126 (c5481a2) into main (5df40fd) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   96.93%   97.41%   +0.48%     
==========================================
  Files          12       11       -1     
  Lines         847      852       +5     
==========================================
+ Hits          821      830       +9     
+ Misses         26       22       -4     
Impacted Files Coverage Δ
...tly_resampler/figure_resampler/figure_resampler.py 90.35% <100.00%> (+1.35%) ⬆️
...ler/figure_resampler/figure_resampler_interface.py 99.72% <100.00%> (+<0.01%) ⬆️
...sampler/figure_resampler/figurewidget_resampler.py 99.03% <100.00%> (+0.01%) ⬆️
plotly_resampler/__init__.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvdd jvdd merged commit db0d5af into main Oct 22, 2022
@jvdd jvdd deleted the bug_update_axes branch December 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fig.update_xaxes(range=[start,end]) and fig.update_yaxes(range=[start,end]) is not working
3 participants