Skip to content

🌈 adding marker props #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 7, 2023
Merged

🌈 adding marker props #148

merged 18 commits into from
May 7, 2023

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Dec 13, 2022 •
edited
Loading

Updated the description @jvdd

TODO:

  • more tests (e.g. serialization)
  • update basic_example or create a new example @jvdd, as the basic example already is rather large.
    • side note: I would also put the minimal code examples, which are in a <detail> element in the README of the examples.
  • verify docs

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022 •
edited
Loading

Codecov Report

Merging #148 (e7ec2c3) into main (a179f05) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   97.11%   97.15%   +0.03%     
==========================================
  Files          13       13              
  Lines         972      983      +11     
==========================================
+ Hits          944      955      +11     
  Misses         28       28
Impacted Files Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
jvdd
jvdd reviewed Dec 29, 2022
View reviewed changes
@jvdd
Copy link
Member

jvdd commented Jan 4, 2023

TODO: test serialization with hf_marker_size and hf_marker_color

@jonasvdd
Copy link
Member Author

jonasvdd commented Jan 4, 2023

updated the description @jvdd

@jvdd jvdd mentioned this pull request Feb 28, 2023
Open
jvdd and others added 3 commits May 3, 2023 14:33
@jonasvdd
Copy link
Member Author

jonasvdd commented May 4, 2023

test seem to work @jvdd, will perform a first review with updated code somewhere later today!

@jonasvdd
Copy link
Member Author

jonasvdd commented May 5, 2023

Ready for your review @jvdd!

jvdd
jvdd reviewed May 5, 2023
View reviewed changes
plotly_resampler/figure_resampler/figure_resampler_interface.py Outdated
@@ -955,6 +1014,7 @@ def add_trace(
# We copy (by reference) all the non-data properties of the trace in
# the new trace.
trace = trace._props # convert the trace into a dict
# TODO -> do not use this difference -> and use a list of keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate issue for this?

jvdd
jvdd approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - still some work to do for extending the tests etc.

@jonasvdd
Copy link
Member Author

jonasvdd commented May 6, 2023

@jvdd, ready for final review!
fyi, I looked at the serialization code; and it just serializes the hf_data object, with hf_marker_size and hf_marker_color being sub-properties of hf_data (highly similar to hf_x and hf_y). As such, I think that adding extra tests for marker property serializations are not necessary.

jvdd
jvdd approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@jvdd jvdd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just have a second look at the only open comment above

Nice job 🤝

@jonasvdd jonasvdd merged commit e56cbc7 into main May 7, 2023
@jvdd jvdd deleted the marker_props branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdd jvdd jvdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasvdd @codecov-commenter @jvdd