Skip to content

Improve monotonic assert + fix black formatting in vscode #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023
+5 −2
Merged

Improve monotonic assert + fix black formatting in vscode #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3337457
:pencil: improve assert message, see #158
jonasvdd Jan 20, 2023
11805c6
:crossed_swords: remove black formatting color argument, see #161
jonasvdd Jan 20, 2023
865e2a4
:see_no_evil: formatting
jonasvdd Jan 20, 2023
90b18c0
:pen: review code
jvdd Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plotly_resampler/figure_resampler/figure_resampler_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,11 @@ def _construct_hf_data_dict(
hf_series = self._to_hf_series(x=dc.x, y=dc.y)

# Checking this now avoids less interpretable `KeyError` when resampling
assert hf_series.index.is_monotonic_increasing
assert hf_series.index.is_monotonic_increasing, (
"In order to perform time series aggregation, the data must be "
"sorted in time; i.e., the x-data must be (non-strictly) "
"monotonically increasing."
)

# As we support prefix-suffixing of downsampled data, we assure that
# each trace has a name
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ ignore = ["E501"] # Never enforce `E501` (line length violations).

# Formatting
[tool.black]
color = true
line-length = 88

# Sort imports
Expand Down