-
-
Notifications
You must be signed in to change notification settings - Fork 74
🐛 return None when rounding 0 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is ready for review! @jonasvdd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 🔍
I would just add two little tests for the negative time and number check and then it's mergeable!
Negative numbers should now be supported in |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 97.30% 97.31%
=======================================
Files 12 12
Lines 891 894 +3
=======================================
+ Hits 867 870 +3
Misses 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #171
When rounding numbers or timedelta's, None is returned when the number (i.e., diff) == 0