Skip to content

test: add tests for #123 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2023
Merged

test: add tests for #123 #176

merged 3 commits into from
Mar 7, 2023

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Mar 7, 2023

Adds a test for #123, this test whether the FigureResampler.show_dash keeps hanging if a FigureResampler Dash app is already running on the same port.

Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤝

@jvdd jvdd requested a review from jonasvdd March 7, 2023 16:16
@jvdd jvdd merged commit 8df65e1 into main Mar 7, 2023
@jvdd jvdd deleted the test_hanging_show_dash branch March 21, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants