Skip to content

✨ add fill_value option to gap handlers #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023
Merged

✨ add fill_value option to gap handlers #218

merged 3 commits into from
May 24, 2023

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented May 21, 2023

This PR add the fill_value option to the AbstractGapHandler interface, which allows to conveniently fill gaps of traces, that utilize shaded areas via a fill="tozeory".

TODO:

  • update docs for area's and fill-values

@jonasvdd jonasvdd requested a review from jvdd May 21, 2023 10:49
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Merging #218 (ba9dd95) into main (ef0d4e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   97.16%   97.17%           
=======================================
  Files          13       13           
  Lines         989      991    +2     
=======================================
+ Hits          961      963    +2     
  Misses         28       28           
Impacted Files Coverage Δ
...tly_resampler/aggregation/gap_handler_interface.py 95.45% <100.00%> (+0.45%) ⬆️
..._resampler/aggregation/plotly_aggregator_parser.py 94.56% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasvdd jonasvdd merged commit 5bdf444 into main May 24, 2023
@jvdd jvdd deleted the gap_fill_value branch June 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants