-
-
Notifications
You must be signed in to change notification settings - Fork 73
adding requirements.txt for example_folder #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @someshfengde 👋🏼! Thank you for contributing, very valid PR!
|
but if we omit those packages then we cannot run get requirements from one file. Either we can add these additional requirements in |
Hi @someshfengde! I discussed this with @jvdd and he was rather fond of adding these requirements to the poetry dev dependencies. (As otherwise, we would have multiple dependency management systems.) ⬇️ plotly-resampler/pyproject.toml Lines 21 to 39 in cc951c1
But then we made the observation that most users do not at all need / use However, we might want to:
|
yes I've also seen using poetry first time 😄 |
I think you can just re-use this PR and adjust the version lock! |
Yes sure |
also if you are on the latest pip you should be able to just |
ohh thanks |
Hi I've changed and loosened up a requirements a little bit We can add installation instructions in readme.md file itself ( I haven't added it not sure if we should add this or not? ) |
The installation instructions can indeed be added to the readme! |
Will close this PR as this will be handled in #104 |
adding requirements for example_folder will help us to run the application more easily ( before we have to install required modules separately)
we can now just do
pip install -r requirements.txt
and pip will install dependencies for us.