-
Notifications
You must be signed in to change notification settings - Fork 81
Infer version #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Infer version #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in importing semver functionality by independent functions.
I think that once we recover the pragmas we should go for the |
…ring it against the supported versions.
… `>=0.5.0 <=0.6.0` which can be concatenated.
24fc4de
to
0234fa9
Compare
80269dd
to
665c218
Compare
fvictorio
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version inference works as follows:
Simple enough but when developing I encountered cases where:
Therefore, to mitigate errors we calculate milestone versions which are the first and last patch versions of any minor version supported (
0.8.26
,0.8.0
,0.7.6
,0.7.0
,0.6.12
,0.6.0
,0.5.17
,0.5.0
,0.4.26
,0.4.11
).Starting from the latest version, we attempt the original steps.
If there are errors or no pragma statement, we attempt with the next version (this will add a processing tax on older syntaxes)
If the pragma statement is not a supported version (e.g.
0.8.27
), we assume the latest supported version.Another albeit ridiculous thing that could happen is that a developer could add a random comment.
To address this we use our own AST structure, to fetch the comments and replace them manually with empty space from the unparsed version range.