Binary operation grouping and indentation review #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To visually display the operation hierarchy when adding parentheses is too much, prettier groups and indents binary operations (visually matching the behaviour of adding parentheses).
The hierarchy is as follows:
**
*
,/
,%
+
,-
<<
,>>
|
,&
,^
<
,>
,<=
,>=
==
,!=
&&
,||
Many of these cases were already taken care of by adding parentheses in unclear cases or when everything would fit in a single line.
Since all of these behaviours follow the same rule there was a some work put standardising the printers in such a way that the same printer is used for all operations and the only difference is where in the hierarchy the current operator lands.
this was part of #1097 that had too many topics at once.