Error upgrading past v4.0.3 - eslint-plugin-github should be dependency #165
Labels
Comments
chadfawcett
added a commit
to chadfawcett/eslint-plugin-primer-react
that referenced
this issue
May 1, 2024
|
Hey @chadfawcett! Thanks so much for bringing this up, totally agreed too. Not sure how this got removed but it should definitely be a dependency or peerDependency 👍 I'll ask the team to see which one we prefer and respond to the PR that you have open 👀 Thanks again for bringing this up! |
joshblack
pushed a commit
that referenced
this issue
May 6, 2024
* Move eslint-plugin-github to dependencies Resolves #165 * Commit package-lock.json changes * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! Attempting to update past v4.0.3 results in an error when we run our linter saying
eslint-plugin-githubcouldn't be found. It also points toprimer-react/recommendedas the spot that's referencing it.It looks like
eslint-plugin-githubused to be adependencyAND adevDependency, but was removed from thedependenciesin #106.Since you are using
eslint-plugin-githubin the published primer plugin, I think it should be adependencyand not adevDependency.I'm not familiar with the codebase though, so there may be a better explanation. Another option might be to make it a
peerDependency.The text was updated successfully, but these errors were encountered: