Skip to content

[Breaking] Remove no-deprecated-colors plugin #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

langermank
Copy link
Contributor

@langermank langermank commented May 10, 2024

This plugin relies on an older part of the primer/primitives build and doesn't seem necessary anymore with the move towards CSS variables. We will likely want to introduce a newer version of this plugin in the future, but for now I think it make sense to just remove it and cut a major.

  • Removes no-deprecated-colors plugin
  • Removed dep on primer/primitives

@langermank langermank requested a review from a team as a code owner May 10, 2024 17:24
@langermank langermank requested a review from joshblack May 10, 2024 17:24
Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 306b19f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langermank langermank merged commit 2576a9f into main May 13, 2024
7 checks passed
@langermank langermank deleted the remove-color-plugin branch May 13, 2024 18:43
@primer-css primer-css mentioned this pull request May 13, 2024
langermank added a commit that referenced this pull request May 13, 2024
langermank added a commit that referenced this pull request May 13, 2024
@langermank langermank restored the remove-color-plugin branch May 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants