Skip to content

Update session-builder.ts #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update session-builder.ts #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/session-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class SessionBuilder {
const address = this.remoteAddress.toString()
const serialized = await this.storage.loadSession(address)
let record: SessionRecord
if (serialized !== undefined) {
if (serialized !== undefined && serialized != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer checking serialized !== null to avoid the implicit conversions. (Since null == undefined is true we could just say serialized != undefined here and it would eliminate null, but the !== makes things more clear IMO.)

record = SessionRecord.deserialize(serialized)
} else {
record = new SessionRecord()
Expand Down