Skip to content

Feature/require socket.io client instance #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 5, 2018

Conversation

probil
Copy link
Owner

@probil probil commented Apr 5, 2018

No description provided.

@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          77     78    +1     
  Branches       19     19           
=====================================
+ Hits           77     78    +1
Impacted Files Coverage Δ
src/Main.js 100% <100%> (ø) ⬆️
src/utils/index.js 100% <100%> (ø) ⬆️
src/Observer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b68a0...2eb2c4a. Read the comment docs.

@probil probil merged commit 4473ddc into master Apr 5, 2018
@probil probil deleted the feature/require-socket.io-client-instance branch April 5, 2018 21:41
@probil
Copy link
Owner Author

probil commented Apr 5, 2018

Closes #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant