-
-
Notifications
You must be signed in to change notification settings - Fork 37
Migration to vue 3 #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to vue 3 #507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 128 124 -4
Branches 20 20
=========================================
- Hits 128 124 -4
Continue to review full report at Codecov.
|
Got it working. Still don't know why the |
I implemented your suggestions @probil |
@jnt0r also remove files from |
Sorry didn't notice that. Fixed it @probil |
Looks good. Needs README update and can be released as v5 |
I updated README but don't know about Nuxt.js and Quasar Framework and didn't find any example of how they changed to Vue 3. Maybe someone can provide the changes for these two. |
@probil How do you plan to release v5. Will it only be compatible with vue3 and would there be two maintained versions? |
@jnt0r I was thinking to make v5 compatible with vue 3 and vue 2 + composition api. But I haven't test it with the last one so there might be some issues. |
@probil Okay. Maybe I'm able to help you :) |
@jnt0r It seems to be faster to release v5 for vue 3 only for now so those who need to use the library with the newest version of Vue can do so while other can stay on v4. I'll try to release the alpha version later today or tomorrow after work. |
🎉 This PR is included in version 5.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I adjusted the plugin to the vue 3 API. It's working in my current project but I didn't manage to make all the tests green. Will try to achieve it in the next days but feel free to help me :)