Skip to content

Migration to vue 3 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 17, 2021
Merged

Migration to vue 3 #507

merged 13 commits into from
Jan 17, 2021

Conversation

jnt0r
Copy link
Contributor

@jnt0r jnt0r commented Dec 26, 2020

I adjusted the plugin to the vue 3 API. It's working in my current project but I didn't manage to make all the tests green. Will try to achieve it in the next days but feel free to help me :)

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #507 (aab3f24) into master (2ffe457) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          128       124    -4     
  Branches        20        20           
=========================================
- Hits           128       124    -4     
Impacted Files Coverage Δ
src/createMixin.js 100.00% <100.00%> (ø)
src/plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffe457...aab3f24. Read the comment docs.

@jnt0r
Copy link
Contributor Author

jnt0r commented Dec 27, 2020

Got it working. Still don't know why the configStore in plugin.js at line 14 doesn't work anymore. I replaced it with a simple object and only commented the old code. Maybe someone knows why this isn't working anymore.
Any thoughts on my implementation?

@jnt0r
Copy link
Contributor Author

jnt0r commented Dec 28, 2020

I implemented your suggestions @probil

@probil
Copy link
Owner

probil commented Dec 28, 2020

@jnt0r also remove files from dist. They are supposed to be generated automatically during release

@jnt0r
Copy link
Contributor Author

jnt0r commented Dec 28, 2020

Sorry didn't notice that. Fixed it @probil

@probil probil added this to the v5 milestone Dec 28, 2020
@probil
Copy link
Owner

probil commented Dec 28, 2020

Looks good. Needs README update and can be released as v5

@jnt0r
Copy link
Contributor Author

jnt0r commented Dec 28, 2020

I updated README but don't know about Nuxt.js and Quasar Framework and didn't find any example of how they changed to Vue 3. Maybe someone can provide the changes for these two.

@jnt0r
Copy link
Contributor Author

jnt0r commented Jan 3, 2021

@probil How do you plan to release v5. Will it only be compatible with vue3 and would there be two maintained versions?
Because other projects added an if statement for the vue version and run other code for vue3 and vue2 so they are compatible with both versions

@probil
Copy link
Owner

probil commented Jan 3, 2021

@jnt0r I was thinking to make v5 compatible with vue 3 and vue 2 + composition api. But I haven't test it with the last one so there might be some issues.

@jnt0r
Copy link
Contributor Author

jnt0r commented Jan 3, 2021

@probil Okay. Maybe I'm able to help you :)
I just updated the Typescript definition so that works with the new version too. For compatibility, we might have to include both definitions (old and new). Let me know how you want to make it compatible and maybe I can help. I can't wait to test the new version with my current project

@probil
Copy link
Owner

probil commented Jan 4, 2021

@jnt0r It seems to be faster to release v5 for vue 3 only for now so those who need to use the library with the newest version of Vue can do so while other can stay on v4. I'll try to release the alpha version later today or tomorrow after work.
Thanks again for your hard work here 💪

@probil probil changed the base branch from master to alpha January 17, 2021 14:25
@probil probil merged commit 81babd2 into probil:alpha Jan 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants