chore(deps): bump fast-xml-parser from 4.5.1 to 5.0.6 [POC] #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size decrease to confirm IIFE 978.59 kB (decrease: ~6kB) TODO Angular example: f-x-p can be removed from the list of commonjs package!
…monjs) This reproduces the pb seen when running the unit and integration tests
…monjs) This reproduces the pb seen when running the unit and integration tests [skip ci]
tbouffard
added
dependencies
|
🎊 PR Preview 8c2aa72 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3278.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
|
🎊 PR Preview 8c2aa72 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3278.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
tbouffard
added
the
skip CI e2e tests
This reverts commit d130a34.
tbouffard
removed
the
skip CI e2e tests
|
tbouffard
changed the title
This was referenced Mar 10, 2025
|
#3295 has been merged into master, so this POC is no longer needed. |
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: ✅
fast-xml-parser now provides ESM supports, so this improves the tree shaking. This will also remove a warning when integrating bpmn-visualization in Angular application (it complains about usage of commonjs dependencies).
First tests show that the bundle size decrease. IIFE minified is now:
To simplify dependencies management, we don't declare strnum in the package.json. This is a transitive dependency (bpmn-visualization doesn't use it directly in the code), so it is easier to let fxp manage this.
Fixing unit test execution when coverage is enabled
After bumping fxp to v5, unit tests fail on GH Action when running with coverage (at least on Ubuntu), similar to #2933 (review)
It has been reproduced locally and also on macOS.
The first try was to switch from ts-jest to @swc/jest to see if the problem came from ts-jest. The problem remained.
The root cause of the problem was that some babel dependencies (such as the core) used version 7.16, while others used version 7.26.
Aligning all dependencies to v7.26 solved the problem.
Detected issues and provided PR to f-x-p as part of this POC
Tasks