Replace requirejs with webpack to enable ES6+ and non-AMD modules #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack cant seem to keep track of which method belongs to which class, but YUIDoc gives us a way to do that with the "for" secondary tag https://yui.github.io/yuidoc/syntax/index.html
TravisCI pointed this out, thanks TravisCI
This was referenced Jun 9, 2019
|
Some relevant issues: https://github.com/processing/p5.js-sound/issues/228#issuecomment-373515799 |
oshoham
reviewed
Jun 10, 2019
src/filter.js
Outdated
| // p5.LowPass = function() { | ||
| // p5.Filter.call(this, 'lowpass'); | ||
| // }; | ||
| // p5.LowPass.prototype = Object.create(p5.Filter.prototype); |
There was a problem hiding this comment.
@therewasaguy do we want to leave these classes commented out or do we just need to add @for to the jsdoc comments?
src/filter.js
Outdated
| // p5.HighPass = function() { | ||
| // p5.Filter.call(this, 'highpass'); | ||
| // }; | ||
| // p5.HighPass.prototype = Object.create(p5.Filter.prototype); |
There was a problem hiding this comment.
see above comment re: @for
src/filter.js
Outdated
| // p5.BandPass = function() { | ||
| // p5.Filter.call(this, 'bandpass'); | ||
| // }; | ||
| // p5.BandPass.prototype = Object.create(p5.Filter.prototype); |
There was a problem hiding this comment.
see above comment re: @for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@for <className>to satisfy the YUIDoc build step in p5.js repo (cc @Spongman, thought you might have insight on this in case there is anything we're missing be9410a )TO DO (perhaps in a separate PR):