Skip to content

Add visual indication upon save failure #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tirtawr opened this issue Apr 15, 2020 · 7 comments · Fixed by #1471
Closed

Add visual indication upon save failure #1393

tirtawr opened this issue Apr 15, 2020 · 7 comments · Fixed by #1471

Comments

@tirtawr
Copy link
Contributor

tirtawr commented Apr 15, 2020

Nature of issue?

  • New feature request

New feature details:

This is touched a little bit at #1383, but I think the feature is important enough to have its own scope.

Whenever there's a failure on saving a file, there is no visual indication to the user that something has gone wrong. Currently, the user will only know if something is wrong if they are meticulous and realizes that there's no popup telling them that the project saved successfully. I think this is too much to ask of them.

It would be great if we can add a popup to let the user know that something is wrong.

@welcome
Copy link

welcome bot commented Apr 15, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Apr 15, 2020

Thanks for the suggestion! Maybe this could be just as simple as showing the Toast component on an error. Maybe the Toast component could have a visually different error state.

@elit-altum
Copy link
Contributor

@catarak Can I work on this?

@catarak
Copy link
Member

catarak commented Apr 29, 2020

@elit-altum yes!

@RickBr0wn
Copy link
Contributor

@catarak Can I work on this?

Hey @elit-altum, How are you getting on with this. If progress has stalled, no worries, I'd be happy to take it on. Let me know ☺️

@elit-altum
Copy link
Contributor

Hey @RickBr0wn You may go ahead with this! Thank you!

@saijatin28
Copy link
Contributor

saijatin28 commented Jun 23, 2020

@RickBr0wn Hey! Since it's been a while, no issues if the progress has stalled. I've identified the error and will submit a patch soon.

saijatin28 added a commit to saijatin28/p5.js-web-editor that referenced this issue Jun 23, 2020
catarak added a commit to saijatin28/p5.js-web-editor that referenced this issue Jun 29, 2020
catarak added a commit that referenced this issue Jun 29, 2020
feature show toast for project save failure #1393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants