Skip to content

fetch-examples fails due to invalid url #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhoizner opened this issue Jun 24, 2020 · 2 comments · Fixed by #1474
Closed

fetch-examples fails due to invalid url #1473

dhoizner opened this issue Jun 24, 2020 · 2 comments · Fixed by #1474

Comments

@dhoizner
Copy link

Nature of issue?

  • Found a bug

Details about the bug:

  • Operating System: macOS 10.15.5
  • Steps to reproduce this bug:
    npm run fetch-examples fails due to renaming of main branch, the .replace needs to be updated from 'master' to 'main'.
@welcome
Copy link

welcome bot commented Jun 24, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@dhoizner dhoizner mentioned this issue Jun 24, 2020
Merged
3 tasks
@catarak
Copy link
Member

catarak commented Jun 29, 2020

Thanks for reporting!

catarak added a commit to dhoizner/p5.js-web-editor that referenced this issue Jun 29, 2020
@catarak
[processing#1473] Update master to main in examples.js
0346784 
- Update CDN URL links for assets on p5.js website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update examples.js to strip the proper ref name. dhoizner/p5.js-web-editor
2 participants
@dhoizner @catarak