-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Megathread: issues with "About" modal responsive design #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@lindapaiste Can I be assigned to this issue? |
At this stage we looking for feedback and ideas from the community. We are not ready to assign it to anyone. |
We may also think about how we organize these lists of links. Personally I don't think that "Twitter" and "Instagram" make sense under the "New to p5.js?" heading. It makes more sense thematically to put them in some sort of "Community" list, alongside "Forum" and "Discord". We could also consider using icon buttons for social media channels. The pink text on the version numbers makes them look like links, which they aren't. They could be links to the releases on GitHub which documents what was changed in each version. |
@lindapaiste How's this for Mobile Landscape? |
Great idea @lindapaiste ! as a contributor and love for p5.js, can you please suggest how to proceed. |
@lindapaiste I'm wondering if turning this into a dedicated page (like the ones in
Completely agree here! |
@lindapaiste Do you wanna go with the suggestions made by @raclim? |
I agree with @raclim here. Instead of a modal which we are using we can make it a new page like
|
the landscape one is easy to be solved and a pr is created for the same. Mobile screen and logo and scrolling changes can be done if required in issue #2686 |
Hi @lindapaiste, Here is a proposed solution : For bigger screens (1024px), languages with longer words, such as Italian, were overflowing, so changed the width and also changed the space between the footer items: For screen width between (430px to 900px), Changing the size of the logo fixed the overflowing issue: For screen width less than (430px), The flex-direction is changed to row. We can remove the scrolling by reducing the font size and logo size: |
Increasing Access
We want the content to be clear and readable on all screen sizes.
Feature enhancement details
We have a bunch of open issues related to the responsive design of the "About" modal. I'm worried that fixing them one-by-one will just create more problems. We need a more substantial rewrite of this CSS and HTML.
Current issues:
About
modal position of "Contribute" and "Report a bug" is not consistent #2531Report a bug
andcode of conduct
exceeds from about modal when window size is resized #2565Proposed solutions:
about__footer
is not a sibling of the columns.How you can help:
Post some screenshots here of how you think the modal should look at various breakpoints, including landscape mode. You can play around with the HTML and CSS in your browser's dev tools or you can edit a screenshot in a graphics program. Let's not make PRs until we have a clearer vision of the desired behavior.
The text was updated successfully, but these errors were encountered: