Skip to content

In About modal position of "Contribute" and "Report a bug" is not consistent #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #2701
PiyushChandra17 opened this issue Oct 24, 2023 · 19 comments · Fixed by Saikat123Dev/p5.js-web-editor#1

Comments

@PiyushChandra17
Copy link
Contributor

p5.js version

2.8.0

What is your operating system?

Mac OS

Web browser and version

Chrome and 117.0.5938.132

Actual Behavior

In About modal position of "Contribute" and "Report a bug" is not consistent

p5-about

Expected Behavior

In About modal position of "Contribute" and "Report a bug" should be consistent

Steps to reproduce

Steps:

  1. Open the editor
  2. Go to Help dropdown
  3. Click on about
  4. Notice at the end of modal, position of contribute and report a bug is not consistent
@lindapaiste
Copy link
Collaborator

Good catch. We recently added some responsive breakpoints to that component which are better than nothing but not perfect. I bet if you look through the git history of the _about.scss you can see what we used to have. I think there was previously a large left margin on the footer section to align it? We would want to put that back in, but only on large/desktop screens.

@bikrantjajware
Copy link

Hello, is the expected design something like this. Aligned vertically with above columns
image

@Ahmed-Armaan
Copy link

@PiyushChandra17 hello, is this the desired output, the Contribute and report links alligned with the two existing columns? If yes, I would like to create a pr.
Screenshot_20231026_0438291

@Swapnil-2502
Copy link

@lindapaiste As I can see from history there was a larger left padding at the ".about__footer" so putting that back it would look something like this. Is this what you wanted it to be ?

Screenshot 2023-10-27 at 12 04 49 PM

And also "New to p5.js?" and "Resources" which are column title are also not align to column list, so is that ok then ignore it, I just removed there left padding it looks better for me, if you can comment on them as well.

@mhsh312
Copy link
Contributor

mhsh312 commented Oct 28, 2023

Greetings, is this the desired result? If so, let me know so I can make a PR.
image
If not, please specify how the content should be styled.

@PiyushThapaa
Copy link
Contributor

I'd like to work on this issue can you assign it to me?

@yashpandey06
Copy link
Contributor

@PiyushThapaa I am already working on it !!!!

@yashpandey06
Copy link
Contributor

@PiyushThapaa but if you have already done it you can make the pr

@PiyushThapaa
Copy link
Contributor

@PiyushThapaa but if you have already done it you can make the pr

no i haven't
can you please help me
i enable to host the server do you how to host the server locally after cloning

@yashpandey06
Copy link
Contributor

you can simply use docker setup to start a localhost ...go through the contributing docs

@yashpandey06
Copy link
Contributor

@PiyushChandra17 I am going to raise pr for this particular issue soon ...but firstly let me know if you are working on this issue.

Vishal7100jain pushed a commit to Vishal7100jain/p5.js-web-editor that referenced this issue Nov 19, 2023
@udittripathi
Copy link

I can host the application locally using docker but when I make changes in the code it is not getting refreshed in the code. So I have to build a new image every time there is something I am doing wrong. Kindly help me with this.

@shree6
Copy link

shree6 commented Nov 25, 2023

Is this still open? Can i work on it?

@shree6
Copy link

shree6 commented Nov 25, 2023

@udittripathi
Same problem has been there for me.

@udittripathi
Copy link

@shree6 If you find the solution please le me know also

@udittripathi
Copy link

@lindapaiste can u help me with this issue?

@Saikat123Dev
Copy link

Screenshot from 2023-12-18 15-30-15

@shamvrueth
Copy link

@lindapaiste If the issue is still not resolved, can I work on it?

@raclim
Copy link
Collaborator

raclim commented Aug 13, 2024

Closing to organize and conslidate issues, linked in Megathread.

@raclim raclim closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment