-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
In About
modal position of "Contribute" and "Report a bug" is not consistent
#2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In About
modal position of "Contribute" and "Report a bug" is not consistent
#2531
Comments
Good catch. We recently added some responsive breakpoints to that component which are better than nothing but not perfect. I bet if you look through the git history of the |
@PiyushChandra17 hello, is this the desired output, the Contribute and report links alligned with the two existing columns? If yes, I would like to create a pr. |
@lindapaiste As I can see from history there was a larger left padding at the ".about__footer" so putting that back it would look something like this. Is this what you wanted it to be ? And also "New to p5.js?" and "Resources" which are column title are also not align to column list, so is that ok then ignore it, I just removed there left padding it looks better for me, if you can comment on them as well. |
I'd like to work on this issue can you assign it to me? |
@PiyushThapaa I am already working on it !!!! |
@PiyushThapaa but if you have already done it you can make the pr |
no i haven't |
you can simply use docker setup to start a localhost ...go through the contributing docs |
@PiyushChandra17 I am going to raise pr for this particular issue soon ...but firstly let me know if you are working on this issue. |
I can host the application locally using docker but when I make changes in the code it is not getting refreshed in the code. So I have to build a new image every time there is something I am doing wrong. Kindly help me with this. |
Is this still open? Can i work on it? |
@udittripathi |
@shree6 If you find the solution please le me know also |
@lindapaiste can u help me with this issue? |
@lindapaiste If the issue is still not resolved, can I work on it? |
Closing to organize and conslidate issues, linked in Megathread. |
p5.js version
2.8.0
What is your operating system?
Mac OS
Web browser and version
Chrome and 117.0.5938.132
Actual Behavior
In
About
modal position of "Contribute" and "Report a bug" is not consistentExpected Behavior
In
About
modal position of "Contribute" and "Report a bug" should be consistentSteps to reproduce
Steps:
The text was updated successfully, but these errors were encountered: