Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Popup Doesn’t Open When Find Popup is Active (via UI or Shortcut) #3428

Open
Jatin24062005 opened this issue Apr 4, 2025 · 1 comment
Labels

Comments

@Jatin24062005
Copy link
Contributor

Jatin24062005 commented Apr 4, 2025

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

When the Find popup is open (triggered via UI or the Ctrl + F shortcut), attempting to open the Replace popup (via UI or Ctrl + H shortcut) fails. The Find popup remains active, and the Replace popup does not appear until the user manually closes the Find popup.

This affects the user experience, as expected behavior would be to automatically switch between Find and Replace popups seamlessly.

p5.js.Web.Editor.-.Brave.2025-04-04.18-20-56.mp4

Expected Behavior

When the Replace popup is triggered, the Find popup should automatically close, and the Replace popup should be immediately visible.

Steps to reproduce

  1. Open the p5.js Web Editor.
  2. Press Ctrl + F or click the Find option → the Find popup appears.
  3. Now press Ctrl + H or click the Replace Text option.
@LalitNarayanYadav
Copy link

Hi @therewasaguy @limzykenneth, could you please review this fix for #3428 when you have time?
This resolves the Find/Replace popup conflict. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants