Skip to content

Folder can be renamed to "" empty string #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marton6 opened this issue Mar 25, 2019 · 7 comments
Closed

Folder can be renamed to "" empty string #989

Marton6 opened this issue Mar 25, 2019 · 7 comments

Comments

@Marton6
Copy link
Contributor

Marton6 commented Mar 25, 2019

Nature of issue?

  • Found a bug

Details about the bug:

It is possible to clear the name of a folder by renaming it to "" and files can be renamed to only contain a valid extension (".js", ".css" etc.).
Moreover two or more folders with an empty name ("") can be contained in the same folder which will probably cause issues.

  • Web browser and version: Chrome 71.0.3578.98
  • Operating System: Windows and Linux
  • Steps to reproduce this bug:
    1. Create a folder with a proper name.
    2. Click rename in the file navigator.
    3. Clear the name of the folder and click outside of it.

Screenshot_20190325_220842

@siddhant1
Copy link
Contributor

Looks like a bug to me , will fix this soon!

@catarak
Copy link
Member

catarak commented Mar 26, 2019

thanks for reporting! this is a bug and i can reproduce.

@siddhant1
Copy link
Contributor

@catarak I think just adding a length cap might work?

@siddhant1
Copy link
Contributor

I think as discussed on #962 (comment) we should also add some validations at the backend and s3

@catarak
Copy link
Member

catarak commented Apr 2, 2019

i think there should be frontend and backend validations.

@olalekanteeblaze
Copy link

I'm a first time contributor, is this still open for me to work on?

@siddhant1
Copy link
Contributor

siddhant1 commented Apr 10, 2019

Hey sure , go for it ! What you need to do to counter this one.

  1. Add backend model level validations for folder name
  2. Add a front end validation or some sort of min length validation
  3. I think we have some prs already doing the 1 , you can pick up (2).

If you have any doubt , most people here will be happy to help(or just tag me).
Congratulations of your first oss project.
Cheers!

@catarak catarak assigned catarak and raclim and unassigned catarak Jun 21, 2019
raclim added a commit to raclim/p5.js-web-editor that referenced this issue Jun 30, 2019
@catarak catarak closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants