Skip to content

Modified Development Docs #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Modified Development Docs #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0994c2c
modified development docs
Khensura21 Feb 10, 2020
fc65f82
Merge branch 'master' of https://github.com/processing/p5.js-web-editor
Khensura21 Mar 31, 2020
d8a3e73
Added backend logic for sketch private prop
Khensura21 Apr 2, 2020
e715acb
Merge branch 'master' of https://github.com/processing/p5.js-web-editor
Khensura21 Apr 7, 2020
95aacc0
add sketch tab and privacy button to setting modal
Khensura21 Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions client/modules/IDE/components/Preferences.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ class Preferences extends React.Component {
<TabList>
<div className="tabs__titles">
<Tab><h4 className="tabs__title">General Settings</h4></Tab>
{/* add sketch tab to the preference modal */}
<Tab><h4 className="tabs__title">Sketch Settings</h4></Tab>
<Tab><h4 className="tabs__title">Accessibility</h4></Tab>

</div>
</TabList>
<TabPanel>
Expand Down Expand Up @@ -230,6 +233,15 @@ class Preferences extends React.Component {
</div>
</div>
</TabPanel>
<TabPanel>
<div className="preference">
<h4 className="preference__title">Privacy Settings</h4>
<div className="preference__options">
<input type="checkbox" />
<label htmlFor="private-output-on" className="preference__option preference__canvas">Make Sketch Private</label>
</div>
</div>
</TabPanel>
<TabPanel>
<div className="preference">
<h4 className="preference__title">Line numbers</h4>
Expand Down
4 changes: 2 additions & 2 deletions developer_docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
A guide for adding code to this project.

## Installation
Follow the [installation guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/installation.md).
⚠️ Before you do anything follow the [installation guide](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/installation.md). ⚠️

## Tests
To run the test suite simply run `npm test` (after installing dependencies with `npm install`)
Expand Down Expand Up @@ -31,4 +31,4 @@ A sample unit test could be found here: [Nav.test.jsx](../client/components/__te

- The ESLint configuration is based on a few popular React/Redux boilerplates. Open to suggestions on this. If in development, you're getting annoyed with ESLint, you can temporarily remove the `eslint-loader` it from `webpack/config.dev.js` in the JavaScript loader, or disable any line from eslint by commenting at the end of the line `// eslint-disable-line`.

- [Jest](https://jestjs.io/) for unit tests and snapshot testing along with [Enzyme](https://airbnb.io/enzyme/) for testing React.
- [Jest](https://jestjs.io/) for unit tests and snapshot testing along with [Enzyme](https://airbnb.io/enzyme/) for testing React.
Loading