Skip to content

Write tests for name verification logic (<ToolBar />, <FileNode />) #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 22, 2020
Merged

Write tests for name verification logic (<ToolBar />, <FileNode />) #1410

merged 8 commits into from
May 22, 2020

Conversation

ghalestrilo
Copy link
Collaborator

@ghalestrilo ghalestrilo commented May 1, 2020

Some additional tests for these two components, just to make sure the logic works as intended, and to prevent it from breaking in the future.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@andrewn
Copy link
Member

andrewn commented May 3, 2020

This is really cool! 🎉

Have you ever used React Testing Library to write tests instead of Enzyme? I've used it in a couple of projects now and it really helps me to write more accessible components. It moves focus into testing how the user experiences the app via labels and text, rather than testing internal details like state or props.

Was thinking it might be worth moving to this while we don't have a huge number of UI tests in the project.

@catarak?

@ghalestrilo
Copy link
Collaborator Author

That's a great idea, I'm all for it!
React Testing Library also seems a lot more future-proof

@catarak
Copy link
Member

catarak commented May 22, 2020

React Testing Library looks awesome! I think it would be worth trying it out in a separate PR and see how it looks compared to the enzyme tests.

@catarak catarak merged commit 67f9824 into processing:master May 22, 2020
@catarak
Copy link
Member

catarak commented May 22, 2020

these tests look good to me for right now!

@catarak
Copy link
Member

catarak commented May 22, 2020

Opened an issue about React Test Framework: #1432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants