Fix issue with fullscreen not appearing (fixes #1445) #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

andrewn merged 1 commit into processing:develop from andrewn:bugfix/fullscreen-1445

Jun 8, 2020

Member

andrewn commented Jun 8, 2020

Fixes #1445

There's more that we should do for this, but I'll do a follow-up PR:

Show 404 if project is not found
Write tests so we know if this page fails because of some change elsewhere

I have verified that this pull request:

has no linting errors (npm run lint)
is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
is descriptively named and links to an issue number, i.e. Fixes #123


          Fix issue with fullscreen not appearing

e264e56

andrewn merged commit 3502844 into processing:develop

andrewn deleted the bugfix/fullscreen-1445 branch

June 8, 2020 08:51

Member

catarak commented Jun 9, 2020

yay thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet