Use React Testing Library instead of Enzyme for tests #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- server tests now use the "node" jest environment, removing the mongoose warning - both projects can use their own jest.setup.js file
catarak
requested changes
Jun 30, 2020
package.json
Outdated
| @@ -13,6 +13,9 @@ | |||
| "build:server": "cross-env NODE_ENV=production webpack --config webpack/config.server.js", | |||
| "build:examples": "cross-env NODE_ENV=production webpack --config webpack/config.examples.js", | |||
| "test": "jest", | |||
| "xxtest": "npm run test:server && npm run test:client", | |||
There was a problem hiding this comment.
Is this the old command to run the tests? Should this be removed?
There was a problem hiding this comment.
Ah, thanks so much for spotting them! This was an experiment before I found out about Jest projects.
I've removed them!
|
This looks great to me! I do really like the switch from testing the internal props/state to the UI itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1432.
This replaces enzyme with React Testing Library.
The
serverandclientcode is run as separate Jest projects which means:server/jest.setup.jsclient/jest.setup.jsI've ported the Toolbar, Nav and FileNode tests to use React Testing Library. By design, it forces a focus on how a user will interact with components. e.g. selecting buttons by text content or associated .
I've also flattened the nested
describeblocks as I found it difficult to follow the flow of tests.I have verified that this pull request:
npm run lint)Fixes #123