Skip to content

Allow deleted sketches in collections to be removed (fixes #1465) #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewn
Copy link
Member

@andrewn andrewn commented Jun 29, 2020

After the discussion about this bug in #1465, I decided that deleted sketches in collections shouldn't disappear. Instead, they should appear in the collection as "Deleted". The user can then decide if they want to remove the item from the collection.

I think this is less confusing and also means we don't have to complicate the sketch-deletion code with finding and deleting collections that reference the deleted project.

Screenshot 2020-06-29 11 27 52

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@andrewn
Copy link
Member Author

andrewn commented Jul 2, 2020

@catarak Since this is a fairly serious bug (the collection page containing a deleted collection doesn't load), I think it's worth merging and leaving #1465 open?

@catarak
Copy link
Member

catarak commented Jul 6, 2020

@catarak Since this is a fairly serious bug (the collection page containing a deleted collection doesn't load), I think it's worth merging and leaving #1465 open?

makes sense to me!

@catarak catarak merged commit 5e0d522 into processing:develop Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants