Added hover color to console "Clear" button #2596
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
| padding-right: #{10 / $base-font-size}rem; | ||
| .preview-console--collapsed & { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| .preview-console__clear:hover { | ||
|
|
||
| background-color: rgba(45, 38, 38, 0.345); |
There was a problem hiding this comment.
We generally don't hard-code colors in the CSS because we have three different themes. What looks good on dark might not look good on light and vice-versa. You would want to use a value from the theme with getThemifyVariable. If you need a new color value that's not already defined then you need to add it to all three themes.
| .preview-console__clear:hover { | ||
|
|
||
| background-color: rgba(45, 38, 38, 0.345); | ||
| border-radius: 20px; |
There was a problem hiding this comment.
You don't need this here since you already added a border-radius to element via line 95.
|
|
||
| background-color: rgba(45, 38, 38, 0.345); | ||
| border-radius: 20px; | ||
| padding: x 5px ; |
There was a problem hiding this comment.
This looks like a mistake.
lindapaiste
changed the title
|
Since it's been a while since this PR has been updated, I've marked it with a "closing soon" label, which signifies that this PR will be closed in 10 days. Please feel free to revisit this to make any further updates or indicate that you would like to keep this open! |
Fixes #2592
Changes: made hover color in clear button
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123