Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Translations for the t&c portion of the Signup Page #3274 #3372

Merged

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Mar 7, 2025

Fixes #3274

Changes:

  1. I have updated the translation.json to solve this issue for French , Portuguese and Korean.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Harshit-7373
Copy link
Contributor Author

Harshit-7373 commented Mar 7, 2025

@raclim I know English, Hindi, French, Portuguese, and Korean and I have recently studied Bengali. I saw in the files for English , Hindi and Bengali that the translation for the T&C portion of the signup page was already corrected, but for the rest of the languages, it was not correct. So, I have updated these three files. I am currently learning and understanding a different language. Soon, I will create a PR to solve this issue." Please review this PR and merge it.

@Harshit-7373
Copy link
Contributor Author

Screenshot 2025-03-07 at 5 43 45 PM This is one of the Screenshot related to the french language. That shows that the issue is resolved . This PR corrects and updates the issue in the translation.json file for the Signup Page.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your work on this, I think this looks good!

@raclim raclim merged commit 2d35c97 into processing:develop Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the t&c portion of the signup page isn't translated correctly
2 participants