Skip to content

Fix: Update results count dynamically in Find window. #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Mar 7, 2025

Fixes #1859

Changes:

  1. Fixed the issue where the results count in the Find window did not update immediately. Replaced redundant getSearchState(cm) calls with state in event listeners to ensure dynamic results count updates.
    I have verified that this pull request:
  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixed the issue where the results count in the Find window did not update immediately. Replaced redundant getSearchState(cm) calls with state in event listeners and cleaned up unnecessary comments to ensure consistent and dynamic results count updates.
@Jatin24062005
Copy link
Contributor

Hey @Harshit-7373,
Since this issue no longer exists—possibly due to a fix in another PR or a recent update—there may be no need to solve it anymore.
if it may exists The issue is related to search, Me, @raclim and @kammeows are already working on it in PR #3362. It would be better to discuss and suggest changes there. However, the issue itself doesn’t seem to be present anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results count does not get updated in Find
2 participants