Skip to content

fixing Search Auto-Update After Content Changes Dynamically #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Jatin24062005
Copy link
Contributor

@Jatin24062005 Jatin24062005 commented Mar 18, 2025

This PR fixes an issue where the search match counter does not update dynamically when content is modified.

Fixes #3405

Changes:
Add a change event listener to detect content modifications and restart the search

p5.js.Web.Editor.-.Google.Chrome.2025-03-06.17-32-56.mp4
  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2025

Closing due to reasons outlined in the attached issue.

@raclim raclim closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search (CTRL+F) Doesn't Auto-Update After Content Changes
2 participants