Skip to content

Use jsdelivr as a CDN to fix broken links #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

davepagurek
Copy link
Contributor

@davepagurek davepagurek commented Apr 18, 2025

In #3457 we noticed that some CDN links were broken, and changed the version back to 1.11.3.

It seems that this is a cloudflare CDN issue, with them not updating especially quickly when we release a new version. In the past we switched to jsdelivr as our CDN on the p5.js website as they seem to update much more quickly. I had started using jsdelivr URLs in the version picker here too, but only when you start to change the version -- the default was using Cloudflare as before. So a possible solution is to just use jsdelivr as the default.

Changes:

  • Bumps default version back to 1.11.5
  • Makes the initial sketch use jsdelivr instead of cloudflare cdnjs
    • We still detect cloudflare CDN links, we just don't use them when you switch versions

The p5 version in the default sketch seems to work now!

image

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Apr 18, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming and updating the links, I'll push this out!

@raclim raclim merged commit a615402 into processing:develop Apr 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants