hindi translation of about page and remaining parts of p5.js #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raclim
approved these changes
May 21, 2025
There was a problem hiding this comment.
Thanks for working on this @takshittt and thanks @yugalkaushik for verifying!
I think this PR seems to be addressing missing translations in the Keyboard Shortcuts modal rather than the About page, which is the original issue, so I removed the line in the description pertaining to that.
I think this is overall a positive change, so even though it doesn't touch a specific issue we can merge this in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Hindi translations across various UI components of the p5.js Web Editor especially the 'about' page.
I have verified that this pull request:
npm run lint)npm run test)developbranch.#3485