Skip to content

Added "Create folder" keyboard shortcut #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

takshittt
Copy link
Contributor

Fixes #3383, #3376

Changes:

  • Added a keyboard shortcut for creating a new folder: Ctrl/Cmd + Alt/Option + Shift + N.
  • This follows common conventions in development environments and avoids conflicts with existing shortcuts used by the editor or browsers.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3383, #3376

@takshittt takshittt changed the title Create folder keyboard shortcut Added "Create folder" keyboard shortcut May 23, 2025
@yugalkaushik
Copy link
Contributor

@takshittt The Ctrl/Cmd + Alt/Option + Shift + N shortcut feels a bit tricky to use, such long key combinations don't really function as shortcuts anymore. I'd suggest switching to something shorter, like Ctrl/Cmd + Shift + N, after verifying no conflicts.

@takshittt
Copy link
Contributor Author

Hi @yugalkaushik,

Initially, the plan was to implement Ctrl/Cmd + Shift + N as the shortcut, but that combination conflicts with browser behavior—it’s commonly used to open a private/incognito window. I also considered Option/Alt + Shift + N, but after reviewing the codebase, it seems that introducing new modifier logic would increase complexity.

The combination Ctrl/Cmd + Alt/Option + Shift + N aligns with the existing pattern for implementing shortcuts and avoids OS-level conflicts. I’ve also discussed this in the related issue thread. That said, I agree that such long combinations may not be ideal from a usability standpoint, and it could be worth exploring a more optimal solution.

Would love to hear your thoughts on this.

@yugalkaushik
Copy link
Contributor

Thanks for the detailed explanation! To address the usability concerns with Ctrl/Cmd + Alt/Option + Shift + N, I suggest switching to Ctrl/Cmd + Shift + M. It’s a simpler three-key combo, and less likely to conflict with browser shortcuts. It should also be easier for users, including those with assistive tech like screen readers.
Could you verify if this fits the codebase’s shortcut pattern and test for conflicts across platforms?

@takshittt
Copy link
Contributor Author

Cmd/Ctrl + Shift + M — this one’s already widely used by browsers (especially Chrome and Firefox) to toggle device emulation mode in DevTools. Since our users are likely to be developers, overriding this could interfere with a familiar and essential workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Shortcut Keys for Rename, Create File, and Create Folder in Project Structure Tab
2 participants