Update/Updated Generative Design Examples #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- data files not served via rawgit - hallelujah! - added jquery
|
I noticed that in the PR you linked, it uses p5 version 0.7.2. Do you want to change the p5 version here to 0.7.1 or 0.7.2? |
|
great! i'll merge this in now. |
|
Super! Thanks so much @catarak 🌈🙌 |
|
@joeyklee just ran the script to update the examples, let me know that it worked! |
|
@catarak - thanks! I switched from raw git to githack I think there might be some issues with the way that images are served up via those URLs. E.g. https://editor.p5js.org/generative-design/sketches/P_4_1_2_02 doesn't load the image via:
Just flagging this in case you need to switch any of your other examples over from rawgit to something else. I will look into the fix here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The Generative Design group recently did a review and update of the Generative Design Examples (see: generative-design/Code-Package-p5.js@c40b36e). We'd love to do a bulk update of the examples in the p5 web editor when you get a chance!
If you don't mind running the
npm run fetch-examples-ggso that all the sketches in thegenerative-designaccount are updated, that would be super. We currently have our examples running directly on our site and include a link to the P5 editor for people to jump into the code if they are curious :)Thanks so much @catarak 🌈❤️✨!