Skip to content

Code Embed Iteration #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 1, 2024
Merged

Code Embed Iteration #51

merged 14 commits into from
Apr 1, 2024

Conversation

outofambit
Copy link
Collaborator

@outofambit outofambit commented Mar 21, 2024 •
edited
Loading

  • redo props interface for CodeFrame to support new use cases (supporting css and html code too)
  • converts CodeFrame to a TypeScript file to catch errors of usage earlier
  • rename CodeEmbed to remove Code Mirror prefix
  • adds reset button to CodeEmbed
  • converts SketchEmbed into an Astro component
  • adds tests for CodeEmbed and CodeFrame
    • notably, this required adding network mocking to our test suite and a cached version of p5.min.js to the repo

@outofambit outofambit marked this pull request as ready for review March 25, 2024 05:23
@outofambit outofambit requested a review from stalgiag March 25, 2024 05:23
@stalgiag
Copy link
Collaborator

@davepagurek just wanted to clue you in on this update since you've been working with code frames already. I ran through the tutorials and didn't see any issues but wanted to be sure you noticed that these changes are inbound

@outofambit outofambit enabled auto-merge (squash) April 1, 2024 18:28
@outofambit outofambit merged commit 9f50dec into main Apr 1, 2024
4 checks passed
@outofambit outofambit deleted the code-embed-next branch April 1, 2024 19:15
calebfoss pushed a commit to calebfoss/p5.js-website that referenced this pull request Jan 27, 2025
@outofambit @calebfoss
Code Embed Iteration (processing#51)
540992a 
* rename code embed component

* redo props interface

* add reset button

* convert sketchembed to astro file

* update imports

* extract p5 version to a global

* make code frame typescript

* add codeframe tests

* add test for code embed component

* docs

* Update .eslintignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalgiag stalgiag Awaiting requested review from stalgiag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outofambit @stalgiag