p5.Vector.setHeading uses radians, even when angleMode(DEGREES) is specified

[oleboleskole3]

Most appropriate sub-area of p5.js?

• Accessibility (Web Accessibility)
• Build tools and processes
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Friendly error system
• Image
• IO (Input/Output)
• Localization
• Math
• Unit Testing
• Typography
• Utilities
• WebGL
• Other (specify if possible)

Details about the bug:

• p5.js version: 1.4.0
• Web browser and version: Chrome v96.0.4664.45
• Operating System: Windows
• Steps to reproduce this:

function setup() {
  angleMode(DEGREES)
  const vector = createVector(0, 1)
  vector.setHeading(1)
  console.log(`Expected: 1, Received: ${vector.heading()}`)
}

Logs Expected: 1, Received: 57.29577951308232 to the console, but

function setup() {
  angleMode(RADIANS)
  const vector = createVector(0, 1)
  vector.setHeading(1)
  console.log(`Expected: 1, Received: ${vector.heading()}`)
}

Logs Expected: 1, Received: 1 to the console

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[awelles]

p5.Vector.fromAngle() and p5.Vector.fromAngles() also ignore angleMode(DEGREES)

[limzykenneth]

Fixing this would probably count as a breaking change so I'm not 100% sure if we want to fix this as this stage. Alternatively on the vector and angle related functions documentation we can add a note about this and suggestion to use radians() to convert the values where needed.

[Willyham]

Please add this to the docs 🙏 . I just got tripped up by this for a few hours until I read the source and realised it only took radians as input.

[limzykenneth]

I'm having a reverse on opinion here and think all angle related methods under p5.Vector probably should be respecting angleMode() because heading() and angleBetween() are already doing so but the rest isn't, creating a pretty inconsistent experience that will more likely to be viewed as a bug.

[KevinGrajeda]

Functions in p5.Vector taking angleMode() into consideration:

• heading()
• setHeading()
• rotate()
• angleBetween()
• fromAngle()
• fromAngles()

should we make setHeading(),fromAngle() and fromAngles() use the current angleMode()?
@limzykenneth i would like to have your opinion on this so i can start making changes.

[KevinGrajeda]

@jeffawang, @AdilRabbani, I would also like to know your opinion.

[limzykenneth]

@KevinGrajeda You can file PRs to apply angle mode to those functions.

[jeffawang]

@jeffawang, @AdilRabbani, I would also like to know your opinion.

Thanks for finding other instances that need to change. I agree witih @limzykenneth's conclusion that it's a breaking change but that it's worth fixing for consistency.

[KevinGrajeda]

hey @limzykenneth i think #5495 closed this by mistake.