Sending a p5.Graphics object into image() spams the console with warnings, reducing performance

[clayheaton]

If you run the createGraphics() example code locally and open your Chrome developer tools, you'll see the following repeated many times:

p5.js says: image was expecting a p5.image for parameter #1, received [object Object] instead. image takes different numbers of parameters depending on what you want to do. Click this link to learn more: [http://p5js.org/reference/#p5/image]

This causes serious performance issues on my computer, spinning up the fan, etc...

The code I used to reproduce it is:

var pg;
function setup() {
  createCanvas(100, 100);
  pg = createGraphics(100, 100);
}
function draw() {
  background(200);
  pg.background(100);
  pg.ellipse(pg.width/2, pg.height/2, 50, 50);
  image(pg, 50, 50);
  image(pg, 0, 0, 50, 50);
}

[lmccart]

looks like we are missing support for p5.Graphics arg in the validateArguments check, it should be something more like this.

    this._validateParameters('image', arguments, [
      [
        'p5.Graphics',
        'Number',
        'Number'
      ],
      [
        'p5.Image',
        'Number',
        'Number',
        'Number',
        'Number'
      ],
      [
        'p5.Graphics',
        'Number',
        'Number'
      ],
      [
        'p5.Graphics',
        'Number',
        'Number',
        'Number',
        'Number'
      ]
    ]);

however, this still create the warning unless the p5.Image block is removed completely.

@crhallberg any thoughts on what might need to change about the validateArguments function?

[lmccart]

@ccheaton in the meantime, you can use p5.min.js file which doesn't have this error checking.

[clayheaton]

@lmccart Thanks. I've been trying to stick with the unminified version to familiarize myself with the codebase, in hopes of contributing in the future. I'll stick with p5.min.js for anything meant for production.