Updated Image Reference Examples on p5js.org to ES6 #3404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duskvirkus
changed the title
lmccart
reviewed
Dec 22, 2018
| * var x, y, d; // set these to the coordinates | ||
| * var off = (y * width + x) * d * 4; | ||
| * var components = [ | ||
| * ```javascript |
There was a problem hiding this comment.
I don't think this will render correctly. have you tested it?
There was a problem hiding this comment.
Yeah I tested it. It currently displays as code but is hard to read because it doesn't have any line breaks you can see that here:
I chose to match the syntax that I saw in other places throughout the image docs. Here's the suggested change displayed with npm run docs:dev:
I can change it back if you like but I think this is easier to understand.
There was a problem hiding this comment.
this looks good. thanks for posting the screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #3387
@examplesfor@module Imageto ES6=>notation<code></code>block by changing it to```javascript```so it displays correctly