Skip to content

feat: enable Github Issue Forms #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 18, 2022
Merged

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Nov 24, 2021

Resolves #5414

Changes:

Replaced the existing Markdown issue templates with GitHub issue forms. I believe that the forms make it easier to contribute to p5.js, which furthers its mission of improving access.

To preview the new functionality, feel free to open an example issue in my fork.

Screenshots of the change:

User view upon selecting "new issue":
image
User view upon selecting "Existing Feature Enhancement":
image

@welcome
Copy link

welcome bot commented Nov 24, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@willmartian willmartian mentioned this pull request Nov 24, 2021
17 tasks
Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better than I expected and I think really would make not just authoring an issue but also for us going through an open issue much easier!

A few changes inline.

@outofambit @Qianqianye Would you like to have a look at this as well?

Copy link
Contributor

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this @willmartian, I'm really excited to get this in! left a few comments, let me know what you think? :D

@willmartian
Copy link
Contributor Author

Thanks for the reviews all! And the patience, I stopped looking at GitHub over the holiday :)

I think I implemented all of the requested changes--let me know if there is anything else @outofambit

@limzykenneth
Copy link
Member

Thanks! I'll merge this in a couple days if there are no further comments.

@limzykenneth limzykenneth merged commit 721bd45 into processing:main Jan 18, 2022
@limzykenneth
Copy link
Member

Merged. There's a few things I may want to tweak but for now, let's give this a go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Issue Forms
3 participants