docs(src/math): Use describe() instead of @alt
#5596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@lm-n ping 😇 |
lm-n
reviewed
Feb 20, 2022
| @@ -303,13 +298,12 @@ p5.prototype.radians = angle => angle * constants.DEG_TO_RAD; | |||
| * angleMode(RADIANS); // Change the mode to RADIANS | |||
| * rotate(a); // variable a stays the same | |||
| * rect(-40, -5, 20, 10); // Smaller rectangle is rotating in radians | |||
| * describe(`40×10 rect in center rotates with mouse moves. | |||
There was a problem hiding this comment.
@Zearin could you make a new PR correcting this to 40 by 10. Screen readers would otherwise read this as 40 ex 10
lm-n
reviewed
Feb 20, 2022
| @@ -303,13 +298,12 @@ p5.prototype.radians = angle => angle * constants.DEG_TO_RAD; | |||
| * angleMode(RADIANS); // Change the mode to RADIANS | |||
| * rotate(a); // variable a stays the same | |||
| * rect(-40, -5, 20, 10); // Smaller rectangle is rotating in radians | |||
| * describe(`40×10 rect in center rotates with mouse moves. | |||
| * 20×10 rect moves faster.`); | |||
There was a problem hiding this comment.
here also 20 by 10 otherwise it is read 20 ex 10
1 task
1 task
1 task
This was referenced Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5139. Attention @lm-n. ;-)
Changes:
Use
describe()over@altin inline docs within 📁 src/math/.PR Checklist
npm run lintpasses