Skip to content

Changed em tags (asterisks) to multiplication symbols #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2023

Conversation

Acha0203
Copy link
Contributor

@Acha0203 Acha0203 commented Jun 6, 2023

Changes:
Changed em tags to multiplication symbols in src/core/transform.js

before:
@param {Array} arr an array of numbers - should be 6 or 16 length (2*3 or 4*4 matrix values)

after:
@param {Array} arr an array of numbers - should be 6 or 16 length (2×3 or 4×4 matrix values)

PR Checklist

@welcome
Copy link

welcome bot commented Jun 6, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@inaridarkfox4231
Copy link
Contributor

inaridarkfox4231 commented Jun 6, 2023

Thank you for noticing typos!
That's right, but there are other typos.

エックスとばつ

 /**
 * @param  {Number} a numbers which define the 2×3 or 4x4 matrix to be multiplied
 */

As you can see from this, the multiplication symbol "×" and the alphabet "x" are mixed. So I think you should fix this as well.
I think the multiplication symbol is more appropriate.

@Acha0203
Copy link
Contributor Author

Acha0203 commented Jun 7, 2023

I have changed the characters of x to multiplication symbols. Thank you!

@davepagurek
Copy link
Contributor

davepagurek commented Jun 7, 2023

I think your changes look good! I think we don't need to update package-lock for this change, do you mind unstaging those changes? I think that can be done with git checkout main -- package-lock.json and committing the results.

@Acha0203
Copy link
Contributor Author

I have entered the command you said and committed the results. If you have any problems or questions, please let me know. Thank you!

@limzykenneth limzykenneth merged commit 0727237 into processing:main Jun 10, 2023
@limzykenneth
Copy link
Member

Looks good. Thanks!

@Acha0203 Acha0203 deleted the fix/applymatrix-description branch June 11, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants