Skip to content

Configurable automatic cleanup for Successful AppWrappers #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgrove-oss opened this issue Feb 9, 2024 · 1 comment · Fixed by #124
Closed

Configurable automatic cleanup for Successful AppWrappers #15

dgrove-oss opened this issue Feb 9, 2024 · 1 comment · Fixed by #124
Assignees
@dgrove-oss
Labels
enhancement New feature or request

Comments

@dgrove-oss
Copy link
Collaborator

Consider adding configurable automatic cleanup after completion of an AppWrapper.

Can draw inspiration from similar feature on Jobs (https://kubernetes.io/docs/concepts/workloads/controllers/job/#ttl-mechanism-for-finished-jobs).

We may want to have different default behavior for successful vs. failed jobs.
@dgrove-oss dgrove-oss added the enhancement New feature or request label Feb 9, 2024
@dgrove-oss dgrove-oss self-assigned this Apr 1, 2024
@dgrove-oss dgrove-oss changed the title Configurable automatic cleanup after AppWrapper completion Configurable automatic cleanup for Successful AppWrappers Apr 1, 2024
@dgrove-oss
Copy link
Collaborator Author

dgrove-oss commented Apr 1, 2024 •
edited
Loading

For failed jobs, this was done in #71.

For AppWrappers that end in the Succeeded state we follow MCAD and do not delete the resources until the AppWrapper itself is deleted. It would be fairly easy to add automatic deletion in the Succeeded state (after a fairly long time period, as a Succeeded AppWrapper has no pods and therefore is not consuming significant resources).

dgrove-oss added a commit to dgrove-oss/appwrapper that referenced this issue Apr 30, 2024
@dgrove-oss
Configurable automatic deletion of resources for Succeeded AppWrappers
970b3a4 
Fixes project-codeflare#15.
@dgrove-oss dgrove-oss mentioned this issue Apr 30, 2024
Merged
dgrove-oss added a commit that referenced this issue Apr 30, 2024
@dgrove-oss
Configurable automatic deletion of resources for Succeeded AppWrappers (
802c322 
#124)

Fixes #15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrove-oss dgrove-oss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable automatic deletion of resources for Succeeded AppWrappers dgrove-oss/appwrapper
1 participant
@dgrove-oss