Skip to content

Implement delayed forceful deletion of pods & resources #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgrove-oss opened this issue Mar 1, 2024 · 0 comments · Fixed by #71
Closed

Implement delayed forceful deletion of pods & resources #36

dgrove-oss opened this issue Mar 1, 2024 · 0 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request

Comments

@dgrove-oss
Copy link
Collaborator

Workload pods may become stuck (fail to delete). MCAD implemented an optional forceful deletion where after a user-specified grace period, MCAD would forcefully delete (delete with graceperiod 0) all remaining pods of a deleted workload.

The code that does this in mcadv2 is here: https://github.com/project-codeflare/mcad/blob/4dffea6bb957248dda957d9d97ec62fb19b7b9dc/internal/controller/resource_manager.go#L216-L241

We need similar functionality in the AppWrapper controller, but should drive it by looking for an annotation that enables it (and sets the deletion grace period) and by using timestamps in conditions instead of adding additional specialized fields to the status.

@dgrove-oss dgrove-oss added the enhancement New feature or request label Mar 1, 2024
@dgrove-oss dgrove-oss self-assigned this Mar 26, 2024
dgrove-oss added a commit to dgrove-oss/appwrapper that referenced this issue Mar 29, 2024
dgrove-oss added a commit to dgrove-oss/appwrapper that referenced this issue Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant