Skip to content

Distinguish NoSchedule and NoExecute Autopilot labels #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Distinguish NoSchedule and NoExecute Autopilot labels #218

merged 3 commits into from
Jul 26, 2024

Conversation

tardieu
Copy link
Member

@tardieu tardieu commented Jul 26, 2024

This PR introduces a distinction between NoSchedule and NoExecute Autopilot labels, which are configured using the syntax of taints:

     autopilot:
        injectAntiAffinities: true
        monitorNodes: true
        resourceTaints:
          nvidia.com/gpu:
          - key: autopilot.ibm.com/gpuhealth
            value: EVICT
            effect: NoExecute
          - key: autopilot.ibm.com/gpuhealth
            value: ERR
            effect: NoSchedule

When a resource on a node is labeled with effect NoSchedule the node capacity for this resource is subtracted from the lending limit on the slack cluster queue, but workloads already running on the node are not impacted.

When a resource on a node is labeled with effect NoExecute the lending limit is reduced and, in addition, workloads running on the node and using the resource are reset.

This PR also adjusts lending limits for cordoned nodes.

@tardieu tardieu requested a review from dgrove-oss July 26, 2024 03:11
Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tardieu tardieu added the enhancement New feature or request label Jul 26, 2024
@tardieu tardieu changed the title Distinguish NoSchedule and NoSchedule Autopilot labels Distinguish NoSchedule and NoExecute Autopilot labels Jul 26, 2024
@tardieu tardieu merged commit fae2af0 into main Jul 26, 2024
2 checks passed
@tardieu tardieu deleted the taints branch July 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants