Skip to content

Add method to create rolebinding for user in namespace scope #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented May 30, 2024

Issue link

related to https://github.com/project-codeflare/integration-tests/pull/4

What changes have been made

  • Add CreateUserNamespaceRoleBinding function which can give namespace specific scope access to user with specified role.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@abhijeet-dhumal abhijeet-dhumal force-pushed the add-user-ns-rolebinding branch 2 times, most recently from 5620f13 to 50adb86 Compare May 30, 2024 09:28
@abhijeet-dhumal abhijeet-dhumal requested a review from sutaakar May 30, 2024 09:30
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-user-ns-rolebinding branch 2 times, most recently from 9957915 to e9217d4 Compare May 31, 2024 08:47
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-user-ns-rolebinding branch from e9217d4 to 6127902 Compare May 31, 2024 12:24
Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c80701 into project-codeflare:main May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants