Ray cluster client redesign #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutaakar
changed the title
sutaakar
force-pushed
the
ray-cluster
branch
from
50a73ec to
5f67386
Compare
astefanutti
approved these changes
Sep 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2f60dc7
into
project-codeflare:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Rewritten
NewRayClusterClientfunction to accept onlyRayClusterClientConfigwith all the needed configuration.RayClusterClientConfigallows users to passhttp.Clientwith any configuration which user needs, providing configuration flexibility.Simplified and adjusted client functions to better reflect underlying REST API.
Purpose is to make Ray client flexible enough to allow its usage outside of RHOAI, potentially donating it to Ray community.
Verification steps
Verified by using the new implementation in ODH/DW repo to run integration tests.
Checks